Skip to content

fix: delete using _rowaddr incorrectly applied to all fragments #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: delete using _rowaddr incorrectly applied to all fragments #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...e-spark-3.5_2.12/src/main/java/com/lancedb/lance/spark/write/SparkPositionDeltaWrite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,14 @@ private LanceDeltaWriter(LanceConfig config, LanceDataWriter writer) {

@Override
public void delete(InternalRow metadata, InternalRow id) throws IOException {
long rowAddr = id.getLong(0);
Copy link
Contributor

@fangbo fangbo Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/lance-format/lance-spark/pull/118/files#diff-8ff2b32a01a531cca5f46144d603cfa63c99bf836f208c0c03950c4980f132acR169 can use this rowAddr

Copy link
Contributor

@fangbo fangbo Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this modification can workaround this problem, I think it's tricky and confusable. Theoretically, the metadata and id should belong to the same row. Which means that they belong to the same Fragment.

I think we also should fix the Fragment.scan's wrong results with filter _rowaddr == 0.

int fragmentIdFromAddr = (int) (rowAddr >> 32);
int fragmentId = metadata.getInt(0);

if (fragmentId != fragmentIdFromAddr) {
return;
}

deletedRows.compute(
fragmentId,
(k, v) -> {
Expand All @@ -159,7 +166,7 @@ public void delete(InternalRow metadata, InternalRow id) throws IOException {
// Get the row index which is low 32 bits of row address.
// See
// https://github.com/lancedb/lance/blob/main/rust/lance-core/src/utils/address.rs#L36
v.add(RowAddress.rowIndex(id.getLong(0)));
v.add(RowAddress.rowIndex(rowAddr));
return v;
});
}
Expand Down