Skip to content

feat: add IVF_HNSW_FLAT index#3671

Merged
BubbleCal merged 5 commits into
lance-format:mainfrom
BubbleCal:expose-flat-hnsw
Jun 20, 2025
Merged

feat: add IVF_HNSW_FLAT index#3671
BubbleCal merged 5 commits into
lance-format:mainfrom
BubbleCal:expose-flat-hnsw

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions Bot added enhancement New feature or request python labels Apr 11, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (1afdf3f) to head (f62eb05).

Files with missing lines Patch % Lines
rust/lance/src/index/vector/ivf.rs 80.00% 0 Missing and 4 partials ⚠️
rust/lance-index/src/lib.rs 66.66% 1 Missing ⚠️
rust/lance/src/index.rs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3671   +/-   ##
=======================================
  Coverage   78.68%   78.69%           
=======================================
  Files         285      285           
  Lines      113471   113516   +45     
  Branches   113471   113516   +45     
=======================================
+ Hits        89289    89326   +37     
- Misses      20758    20761    +3     
- Partials     3424     3429    +5     
Flag Coverage Δ
unittests 78.69% <87.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@SaintBacchus
Copy link
Copy Markdown
Collaborator

@BubbleCal I tested this pr and it works. Will you fix the CI issue and merge it into the next version?

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal marked this pull request as ready for review June 20, 2025 12:32
Copy link
Copy Markdown
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty cool that this was so easy to add. The abstractions you created are really paying off!

@BubbleCal BubbleCal merged commit 5fd8412 into lance-format:main Jun 20, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants