Skip to content

fix: take benchmark can not read dataset#4065

Merged
yanghua merged 3 commits into
lance-format:mainfrom
yanghua:fix-bench-take-issue
Jun 22, 2025
Merged

fix: take benchmark can not read dataset#4065
yanghua merged 3 commits into
lance-format:mainfrom
yanghua:fix-bench-take-issue

Conversation

@yanghua
Copy link
Copy Markdown
Collaborator

@yanghua yanghua commented Jun 21, 2025

No description provided.

@github-actions github-actions Bot added the bug Something isn't working label Jun 21, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (181d179) to head (a7ca4df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4065      +/-   ##
==========================================
- Coverage   78.73%   78.73%   -0.01%     
==========================================
  Files         285      285              
  Lines      113771   113771              
  Branches   113771   113771              
==========================================
- Hits        89576    89575       -1     
  Misses      20766    20766              
- Partials     3429     3430       +1     
Flag Coverage Δ
unittests 78.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Jun 21, 2025

The original code caused this exception:

- called `Result::unwrap()` on an `Err` value: DatasetNotFound { path: "", source: NotFound { uri: "_versions", location: Location { file: "rust/lance-table/src/io/commit.rs", line: 328, column: 23 } }, location: Location { file: "rust/lance/src/dataset/builder.rs", line: 329, column: 35 } }
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

when run this command cargo bench --bench take

@yanghua yanghua requested review from Xuanwo, jackye1995, westonpace and wjones127 and removed request for westonpace June 21, 2025 12:33
Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yanghua yanghua merged commit cf27c3d into lance-format:main Jun 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants