fix: escape type keyword in tracing::info! macros#4068
Merged
jackye1995 merged 1 commit intoJun 23, 2025
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
type keyword in tracing::info! macrostype keyword in tracing::info! macros
type keyword in tracing::info! macrostype keyword in tracing::info! macros
jackye1995
approved these changes
Jun 23, 2025
jackye1995
left a comment
Contributor
There was a problem hiding this comment.
nice catch, looks good to me!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4068 +/- ##
==========================================
- Coverage 78.82% 78.81% -0.02%
==========================================
Files 285 285
Lines 113731 113731
Branches 113731 113731
==========================================
- Hits 89645 89633 -12
- Misses 20650 20665 +15
+ Partials 3436 3433 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Xuanwo
pushed a commit
that referenced
this pull request
Jul 22, 2025
Similar to #4068 Fixes ``` error: no rules expected keyword `type` --> /Users/.../.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/lance-datafusion-0.31.1/src/exec.rs:350:5 | 350 | / tracing::info!( 351 | | target: TRACE_EXECUTION, 352 | | type = EXECUTION_PLAN_RUN, 353 | | output_rows, ... | 359 | | index_comparisons = counts.index_comparisons, 360 | | ); | |_____^ no rules expected this token in macro call ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run into issues due to the use of the
typekeyword intracing::infomacros - this PR replaces it with the escapedr#typeversion.Sample of the error I previously got: