test(java): re-construct tests for merge operation#4483
Merged
jackye1995 merged 14 commits intolance-format:mainfrom Aug 25, 2025
Merged
test(java): re-construct tests for merge operation#4483jackye1995 merged 14 commits intolance-format:mainfrom
jackye1995 merged 14 commits intolance-format:mainfrom
Conversation
majin1102
force-pushed
the
java-test-refactor
branch
from
7e13314 to
fe4daef
Compare
majin1102
changed the title
Contributor
Author
|
@jackye1995 PTAL when you have time |
Contributor
Author
|
@yanghua Could you take a look when you have time? |
yanghua
reviewed
Aug 25, 2025
|
|
||
| @Test | ||
| void testReplaceAsDiffColumns(@TempDir Path tempDir) throws Exception { | ||
| String datasetPath = tempDir.resolve("testMergeNewColumn").toString(); |
Contributor
Author
There was a problem hiding this comment.
Yes, thanks for this
|
|
||
| public static final int TEST_FILE_FORMAT_MAJOR_VERSION = 2; | ||
| public static final int TEST_FILE_FORMAT_MINOR_VERSION = 0; | ||
| protected static Dataset dataset; |
Contributor
Author
There was a problem hiding this comment.
This is only a movement.
We can make it better with @testinstance(TestInstance.Lifecycle.PER_CLASS)
Please take another look
jackye1995
approved these changes
Aug 25, 2025
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
Nice refactoring! looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found merge operation test is not right. It didn't construct by merging a new column, but instead merged some new rows. Although it works, it's not what we wanted.
In the meanwhile the TransactionTest has grown a little tedious and not that friendly to construct multiple testcases on a single operation. So I did a little refactoring.
The work includes: