Skip to content

Conversation

@zhangyue19921010
Copy link
Contributor

Avoid unnecessary get_fragments calling during plan compaction

get_fragments involves deep copying of dataset and fragment, which is pretty heavy.

@github-actions github-actions bot added the bug Something isn't working label Nov 7, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.84%. Comparing base (d8f9dcb) to head (e10541b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5179   +/-   ##
=======================================
  Coverage   81.83%   81.84%           
=======================================
  Files         341      341           
  Lines      140682   140691    +9     
  Branches   140682   140691    +9     
=======================================
+ Hits       115122   115142   +20     
+ Misses      21752    21742   -10     
+ Partials     3808     3807    -1     
Flag Coverage Δ
unittests 81.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Xuanwo Xuanwo merged commit 9ecbd76 into lance-format:main Nov 10, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants