feat(java): support row lineage and cdf apis #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

yanghua merged 8 commits into lance-format:main from yanghua:feat-delta-java

Dec 17, 2025

Collaborator

yanghua commented Nov 27, 2025

No description provided.

github-actions bot added enhancement java labels

yanghua force-pushed the feat-delta-java branch from bfe5852 to f3d65a7 Compare

November 28, 2025 07:07

yanghua marked this pull request as ready for review

November 28, 2025 07:07

chatgpt-codex-connector bot commented Nov 28, 2025

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

jackye1995 reviewed

View reviewed changes

java/src/main/java/org/lance/Dataset.java Outdated Show resolved Hide resolved

jackye1995 reviewed

View reviewed changes

java/lance-jni/src/delta.rs Outdated Show resolved Hide resolved

jackye1995 reviewed

View reviewed changes

java/src/main/java/org/lance/delta/DatasetDelta.java Outdated Show resolved Hide resolved

jackye1995 reviewed

View reviewed changes

java/src/main/java/org/lance/delta/DatasetDeltaBuilder.java Show resolved Hide resolved

jackye1995 reviewed

View reviewed changes

java/lance-jni/src/delta.rs Outdated Show resolved Hide resolved

jackye1995 reviewed

View reviewed changes

java/lance-jni/src/delta.rs Outdated Show resolved Hide resolved

jackye1995 reviewed

View reviewed changes

java/src/test/java/org/lance/DeltaTest.java Outdated Show resolved Hide resolved

jackye1995 reviewed

View reviewed changes

java/src/test/java/org/lance/DeltaTest.java Outdated Show resolved Hide resolved

jackye1995 reviewed

View reviewed changes

java/lance-jni/src/delta.rs Outdated Show resolved Hide resolved

yanghua added 5 commits

December 13, 2025 16:44


          feat(java): support row lineage and cdf apis

92dc727


          refactor

9ba5bbc


          refactor

02dc19c


          address review comments

be71dc9


          address review comments

79e1d59

yanghua force-pushed the feat-delta-java branch from 0a0ab0e to 79e1d59 Compare

December 13, 2025 08:46


          address review comments

ed743fe

Collaborator Author

yanghua commented Dec 13, 2025

Hi @jackye1995 I have addressed your comments. Please take a look. thanks!

majin1102 reviewed

View reviewed changes

Contributor

majin1102 left a comment

Thanks for working on this. Left some comments
PTAL

java/src/main/java/org/lance/delta/DatasetDelta.java Outdated Show resolved Hide resolved

java/src/main/java/org/lance/delta/DatasetDelta.java Outdated Show resolved Hide resolved

java/src/main/java/org/lance/delta/DatasetDelta.java Show resolved Hide resolved

java/src/main/java/org/lance/delta/DatasetDeltaBuilder.java Outdated Show resolved Hide resolved

java/lance-jni/src/delta.rs Show resolved Hide resolved

java/src/main/java/org/lance/Dataset.java Outdated Show resolved Hide resolved

java/src/test/java/org/lance/DeltaTest.java Show resolved Hide resolved


          address review comments

b7c3773

Collaborator Author

yanghua commented Dec 17, 2025

@majin1102 thanks for the review, have addressed your concerns.


          address review comments

a2252b7

majin1102 approved these changes

View reviewed changes

Contributor

majin1102 left a comment

Looks good to me!

yanghua merged commit e4b07fc into lance-format:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement java