Skip to content

Conversation

@yanghua
Copy link
Collaborator

@yanghua yanghua commented Nov 27, 2025

No description provided.

@github-actions github-actions bot added enhancement New feature or request java labels Nov 27, 2025
@yanghua yanghua marked this pull request as ready for review November 28, 2025 07:07
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@yanghua
Copy link
Collaborator Author

yanghua commented Dec 13, 2025

Hi @jackye1995 I have addressed your comments. Please take a look. thanks!

Copy link
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Left some comments
PTAL

@yanghua
Copy link
Collaborator Author

yanghua commented Dec 17, 2025

@majin1102 thanks for the review, have addressed your concerns.

Copy link
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@yanghua yanghua merged commit e4b07fc into lance-format:main Dec 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants