fix: remove credential vending features from python and java bindings #5737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR ReviewSummary: This PR removes credential vending features ( AssessmentNo P0/P1 issues identified. The change is straightforward:
One considerationThe PR disables credential vending features without providing an alternative. From the PR description, this is intentional for the 2.0.0 release to avoid the OpenSSL compatibility issue. However:
The core REST functionality remains enabled, so basic namespace operations should still work. Verdict✅ LGTM for merge - the fix addresses a real blocking issue for the release. |
wjones127
approved these changes
Jan 17, 2026
Contributor
|
This also fixes an issue we are running into involving |
bryanck
approved these changes
Jan 17, 2026
jtuglu1
approved these changes
Jan 17, 2026
Contributor
jtuglu1
left a comment
jtuglu1
left a comment
There was a problem hiding this comment.
This fixes rest namespace for us
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…lance-format#5737) Fixing hanging Spark test: lance-format/lance-spark#177 Without this fix, the additioanl azure and gcp dependencies in credentials vending featrues pulled in native-tls, which requires installing openssl 1.1. When not present, Spark hangs because rust execution fails in a separated thread and it fails silently, and then a semaphore keeps waiting for result. For why it fails silently rather than propagating back, that's another fix needed in Spark, but should not block the release of 2.0.0
Xuanwo
pushed a commit
that referenced
this pull request
Jan 26, 2026
…#5737) Fixing hanging Spark test: lance-format/lance-spark#177 Without this fix, the additioanl azure and gcp dependencies in credentials vending featrues pulled in native-tls, which requires installing openssl 1.1. When not present, Spark hangs because rust execution fails in a separated thread and it fails silently, and then a semaphore keeps waiting for result. For why it fails silently rather than propagating back, that's another fix needed in Spark, but should not block the release of 2.0.0
jackye1995
added a commit
that referenced
this pull request
Jan 26, 2026
…#5737) Fixing hanging Spark test: lance-format/lance-spark#177 Without this fix, the additioanl azure and gcp dependencies in credentials vending featrues pulled in native-tls, which requires installing openssl 1.1. When not present, Spark hangs because rust execution fails in a separated thread and it fails silently, and then a semaphore keeps waiting for result. For why it fails silently rather than propagating back, that's another fix needed in Spark, but should not block the release of 2.0.0
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
…lance-format#5737) Fixing hanging Spark test: lance-format/lance-spark#177 Without this fix, the additioanl azure and gcp dependencies in credentials vending featrues pulled in native-tls, which requires installing openssl 1.1. When not present, Spark hangs because rust execution fails in a separated thread and it fails silently, and then a semaphore keeps waiting for result. For why it fails silently rather than propagating back, that's another fix needed in Spark, but should not block the release of 2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing hanging Spark test: lance-format/lance-spark#177
Without this fix, the additioanl azure and gcp dependencies in credentials vending featrues pulled in native-tls, which requires installing openssl 1.1. When not present, Spark hangs because rust execution fails in a separated thread and it fails silently, and then a semaphore keeps waiting for result.
For why it fails silently rather than propagating back, that's another fix needed in Spark, but should not block the release of 2.0.0