Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
PR ReviewP1: Memory retention in the modern prewarm pathIn the modern (compressed) prewarm branch, each postings.value(idx).as_binary::<i64>().clone()This is a shallow clone — all cached entries retain Arc references to the full batch data buffer. Unlike the legacy path which calls When cache eviction later removes individual posting lists, no memory is freed until every entry from that batch is evicted. If this index has many tokens, eviction becomes effectively a no-op for memory reclamation. Consider either:
P1: No testsThe PR description says "Not run (not requested)," but repository standards require tests for all changes. The prewarm parallelization and the new modern layout code path both introduce new behavior that should be covered. At minimum, a test verifying that the modern prewarm path correctly populates the cache would catch regressions. Minor observations
|
2bf2d35 to
882ac8b
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
b07726d to
ffcf928
Compare
20%+ faster for 2GB index, could be more for larger index