feat: add configurable FTS index prewarm options#6298
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Code ReviewOverall this is a well-structured PR. The approach of separating position data into a dedicated cache during prewarm — so phrase queries avoid a lazy re-read — is sound. The cache flow is correct: Test coverage is solid: both Rust and Python tests verify the cache-entry-count invariant (no growth after prewarmed phrase query), the validation error for no-position indices, and the Python keyword-only argument enforcement. Minor observations (non-blocking)
No P0/P1 issues found. LGTM. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…g/fts-prewarmwithposition # Conflicts: # python/src/dataset.rs # rust/lance-index/src/traits.rs # rust/lance/src/index.rs
…g/fts-prewarmwithposition
Summary
PrewarmOptionsandFtsPrewarmOptionson the Rust side, with dataset plumbing forprewarm_index_with_optionsprewarm_index(..., *, with_position=False)support for FTS indices while keeping the default prewarm path unchanged