Skip to content

feat: expose base scoped store bindings to java#6548

Merged
yanghua merged 4 commits into
lance-format:mainfrom
zhangyue19921010:base-scoped-store-bindings-java
May 12, 2026
Merged

feat: expose base scoped store bindings to java#6548
yanghua merged 4 commits into
lance-format:mainfrom
zhangyue19921010:base-scoped-store-bindings-java

Conversation

@zhangyue19921010
Copy link
Copy Markdown
Contributor

@zhangyue19921010 zhangyue19921010 commented Apr 16, 2026

Tested: Java can write to different S3 buckets within the same multi-base dataset, using different storage configs for each base.

@github-actions github-actions Bot added enhancement New feature or request java labels Apr 16, 2026
@yanghua
Copy link
Copy Markdown
Collaborator

yanghua commented May 6, 2026

@zhangyue19921010 There is a conflict that needs to be resolved.

zhangyue19921010 added 2 commits May 6, 2026 19:30
Copy link
Copy Markdown
Collaborator

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one comment.

.add("indexCacheSizeBytes", indexCacheSizeBytes)
.add("metadataCacheSizeBytes", metadataCacheSizeBytes)
.add("storageOptions", storageOptions)
.add("baseStoreParams", baseStoreParams)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it contain some sensitive information, e.g. AK/SK?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Removed for simplified processing

Copy link
Copy Markdown
Collaborator

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yanghua yanghua merged commit fd076b1 into lance-format:main May 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants