Skip to content

fix: detect table metadata key conflicts in concurrent UpdateConfig#6667

Merged
Xuanwo merged 1 commit into
lance-format:mainfrom
jackye1995:jack/table-metadata-conflict-detection
May 7, 2026
Merged

fix: detect table metadata key conflicts in concurrent UpdateConfig#6667
Xuanwo merged 1 commit into
lance-format:mainfrom
jackye1995:jack/table-metadata-conflict-detection

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

Summary

  • Two concurrent UpdateConfig transactions writing the same table metadata key would silently overwrite each other
  • Add key-level conflict detection for table_metadata_updates in modifies_same_metadata, matching existing behavior for schema_metadata_updates and field_metadata_updates
  • If either transaction uses replace, they always conflict (full-table metadata replacement)
  • Otherwise, only conflict when both touch the same key

Two concurrent UpdateConfig transactions writing the same table metadata
key would silently overwrite each other. Add key-level conflict detection
for table_metadata_updates, matching the existing behavior for
schema_metadata_updates and field_metadata_updates.
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the bug Something isn't working label May 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@Xuanwo Xuanwo merged commit 9082450 into lance-format:main May 7, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants