fix: detect table metadata key conflicts in concurrent UpdateConfig#6667
Merged
Xuanwo merged 1 commit intoMay 7, 2026
Merged
Conversation
Two concurrent UpdateConfig transactions writing the same table metadata key would silently overwrite each other. Add key-level conflict detection for table_metadata_updates, matching the existing behavior for schema_metadata_updates and field_metadata_updates.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateConfigtransactions writing the same table metadata key would silently overwrite each othertable_metadata_updatesinmodifies_same_metadata, matching existing behavior forschema_metadata_updatesandfield_metadata_updatesreplace, they always conflict (full-table metadata replacement)