ci(python): ignore deprecated hf_xet.download_files warning#6700
Merged
westonpace merged 1 commit intolance-format:mainfrom May 6, 2026
Merged
ci(python): ignore deprecated hf_xet.download_files warning#6700westonpace merged 1 commit intolance-format:mainfrom
westonpace merged 1 commit intolance-format:mainfrom
Conversation
huggingface_hub still calls the now-deprecated hf_xet.download_files() on the Xet download path, which under our error::DeprecationWarning filter fails test_write_hf_dataset. Add a narrow ignore so the upstream deprecation doesn't break CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Upstream issue for tracking: huggingface/huggingface_hub#4195 |
wjones127
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_write_hf_datasetis failing on macOS and Windows CI becausehuggingface_hub's Xet download path calls the now-deprecatedhf_xet.download_files(), andpython/pyproject.tomlconfigures pytest witherror::DeprecationWarning.huggingface_hubitself (file_download.py:558), not in Lance —huggingface_hubhas not yet migrated to the newXetSession().new_file_download_group().start_download_file()API.filterwarningsignore for that exact message, matching the existing pattern used for other third-party deprecation noise (boto3, pytorch, distutils, etc.).Failing CI message:
The ignore is scoped to the exact message, so any other
DeprecationWarningstill escalates to a test failure as before. Whenhuggingface_hubmigrates to the XetSession API, this entry can be removed.Test plan
test_write_hf_datasetpasses on macOS and Windows runnersDeprecationWarning-as-error coverage is unchanged (filter only matches thehf_xet.download_files()message)🤖 Generated with Claude Code