Skip to content

ci(python): ignore deprecated hf_xet.download_files warning#6700

Merged
westonpace merged 1 commit intolance-format:mainfrom
westonpace:fix-deprecated-hf-path
May 6, 2026
Merged

ci(python): ignore deprecated hf_xet.download_files warning#6700
westonpace merged 1 commit intolance-format:mainfrom
westonpace:fix-deprecated-hf-path

Conversation

@westonpace
Copy link
Copy Markdown
Member

Summary

  • test_write_hf_dataset is failing on macOS and Windows CI because huggingface_hub's Xet download path calls the now-deprecated hf_xet.download_files(), and python/pyproject.toml configures pytest with error::DeprecationWarning.
  • The deprecation lives in huggingface_hub itself (file_download.py:558), not in Lance — huggingface_hub has not yet migrated to the new XetSession().new_file_download_group().start_download_file() API.
  • Add a narrow filterwarnings ignore for that exact message, matching the existing pattern used for other third-party deprecation noise (boto3, pytorch, distutils, etc.).

Failing CI message:

DeprecationWarning: hf_xet.download_files() is deprecated.
Use XetSession().new_file_download_group().start_download_file() instead.
huggingface_hub/file_download.py:558: DeprecationWarning

The ignore is scoped to the exact message, so any other DeprecationWarning still escalates to a test failure as before. When huggingface_hub migrates to the XetSession API, this entry can be removed.

Test plan

  • CI: test_write_hf_dataset passes on macOS and Windows runners
  • Other DeprecationWarning-as-error coverage is unchanged (filter only matches the hf_xet.download_files() message)

🤖 Generated with Claude Code

huggingface_hub still calls the now-deprecated hf_xet.download_files()
on the Xet download path, which under our error::DeprecationWarning
filter fails test_write_hf_dataset. Add a narrow ignore so the
upstream deprecation doesn't break CI.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added python ci Github Action or Test issues labels May 6, 2026
@westonpace
Copy link
Copy Markdown
Member Author

Upstream issue for tracking: huggingface/huggingface_hub#4195

@westonpace westonpace merged commit ea7c0ea into lance-format:main May 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Github Action or Test issues python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants