Skip to content

fix(rust): avoid pushdown limit/offset for stable row id#6740

Merged
Xuanwo merged 2 commits into
lance-format:mainfrom
yanghua:fix-stable-rowid
May 15, 2026
Merged

fix(rust): avoid pushdown limit/offset for stable row id#6740
Xuanwo merged 2 commits into
lance-format:mainfrom
yanghua:fix-stable-rowid

Conversation

@yanghua
Copy link
Copy Markdown
Collaborator

@yanghua yanghua commented May 12, 2026

When we enable stable row ID, if we update rows, we can not scan updated rows with a limit condition.

image image

@github-actions github-actions Bot added bug Something isn't working A-python Python bindings labels May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 80.00% 1 Missing ⚠️
rust/lance/src/io/exec/filtered_read.rs 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Xuanwo Xuanwo marked this pull request as ready for review May 15, 2026 08:26
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@Xuanwo Xuanwo merged commit 705cc4e into lance-format:main May 15, 2026
35 of 36 checks passed
geruh pushed a commit to geruh/lance that referenced this pull request May 16, 2026
…t#6740)

When we enable stable row ID, if we update rows, we can not scan updated
rows with a limit condition.

<img width="1160" height="418" alt="image"
src="https://github.com/user-attachments/assets/86a9dfbc-bed9-440d-b784-ecc2b638d953"
/>

<img width="1268" height="542" alt="image"
src="https://github.com/user-attachments/assets/4b338fcb-9891-4377-9fef-b2302e72dc03"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-python Python bindings bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants