fix: use physical scan stream for update#6741
Merged
Merged
Conversation
Update rewrites affected rows using the dataset physical schema. Avoid wrapping the scan output in DatasetRecordBatchStream, which may convert internal JSON columns from lance.json/LargeBinary to arrow.json/Utf8 for user-facing reads and cause schema mismatches during rewrite. Add coverage for updating both regular and JSON columns.
Contributor
Author
|
I ran into error when update a table with json type. Hi @Xuanwo @majin1102 , could you help review this when you have time, thanks very much. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
Does this solve #6329? |
wjones127
approved these changes
May 13, 2026
Contributor
wjones127
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update rewrites affected rows using the dataset physical schema. Avoid wrapping the scan output in DatasetRecordBatchStream, which may convert internal JSON columns from lance.json/LargeBinary to arrow.json/Utf8 for user-facing reads and cause schema mismatches during rewrite. Add coverage for updating both regular and JSON columns.
Error msg
Closes #6329