fix: use multipart-aware put for transaction file writes#6750
Merged
jackye1995 merged 3 commits intoMay 13, 2026
Conversation
Transaction files were written using the raw object_store put() which issues a single PUT request. S3 has a 5GB limit on single PUT, so large transactions (>5GB) fail with EntityTooLarge. Use Lance's ObjectStore::put() which routes through ObjectWriter and handles multipart uploads automatically. Resolves lance-format/lance-spark#526
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wkalt
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_transaction_filewas callingobject_store.inner.put()directly, which issues a single S3 PUT request. S3 has a 5GB hard limit on single PUT, so large transaction files (>5GB) fail withEntityTooLarge.ObjectStore::put()which routes throughObjectWriterand handles multipart uploads automatically.Such big transaction file is definitely not recommended, but after all this is indeed a bug in the code itself.
Resolves lance-format/lance-spark#526