fix: decode constant list struct children#6801
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
BubbleCal
approved these changes
May 18, 2026
wjones127
pushed a commit
that referenced
this pull request
May 20, 2026
Fixes #6776. When a constant-encoded child appears under `List<Struct<...>>`, empty list rows must not count as visible child values. The constant decoder was summing definition levels across the whole path, including levels after the list boundary, so a constant sibling could materialize parent-row counts while non-constant siblings materialized list-item counts. This matches the visible-level boundary used by the miniblock and complex all-null decoders, and adds regression coverage for a constant struct child followed by empty lists under a nullable parent struct. Verified with the targeted encoding test and the dataset attached to #6776. (cherry picked from commit 7c25442)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6776.
When a constant-encoded child appears under
List<Struct<...>>, empty list rows must not count as visible child values. The constant decoder was summing definition levels across the whole path, including levels after the list boundary, so a constant sibling could materialize parent-row counts while non-constant siblings materialized list-item counts.This matches the visible-level boundary used by the miniblock and complex all-null decoders, and adds regression coverage for a constant struct child followed by empty lists under a nullable parent struct. Verified with the targeted encoding test and the dataset attached to #6776.