feat: expose granular trace event targets#6853
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
westonpace
left a comment
There was a problem hiding this comment.
I'm a fan of this change but I'm hoping we can do it without modifying existing targets (to add events::) because that change would be disruptive to us.
Also, semi-related, but I've been thinking we should move more (if not all) of our log statements to tracing events. Having both a "log stream" and a "trace event stream" is pretty confusing.
|
For the Azure request-id concern: the final object-store error is preserved through LanceError(IO), and I added regression coverage that an Azure-style x-ms-request-id present in the object-store error text survives; response headers that object_store::RetryError does not expose would still need an upstream object_store change. |
|
|
||
| let lance_error = lance_core::Error::from(err); | ||
| let error_message = lance_error.to_string(); | ||
| assert!(error_message.contains("x-ms-request-id")); |
There was a problem hiding this comment.
I'm surprised the mock store actually includes these
There was a problem hiding this comment.
I think I mocked the response msg somewhere 😆
|
@westonpace can we merge? |
Summary
lance::events::....LANCE_LOGcan filter individual event types directly.Testing
PATH=/Users/beinan/.rustup/toolchains/1.94.0-aarch64-apple-darwin/bin:$PATH cargo fmt --all -- --checkgit diff --checkPATH=/Users/beinan/.rustup/toolchains/1.94.0-aarch64-apple-darwin/bin:$PATH cargo check -p lance-core -p lance-io -p lance-index -p lance -p lance-datafusionPATH=/Users/beinan/.rustup/toolchains/1.94.0-aarch64-apple-darwin/bin:$PATH cargo check --manifest-path python/Cargo.tomluv sync --python 3.12 --no-install-project.venv/bin/maturin develop --uv -vuv run --no-sync --python 3.12 pytest -q python/tests/test_log.py::test_lance_log_filters_trace_event_targets python/tests/test_tracing.py::test_tracing_callbackuv run --no-sync --python 3.12 ruff format --check python/tests/test_log.py python/tests/test_tracing.pyuv run --no-sync --python 3.12 ruff check python/tests/test_log.py python/tests/test_tracing.py