Conversation
| - name: Run cargo fmt | ||
| run: cargo fmt --check | ||
| - name: Run clippy | ||
| #- name: Run clippy |
| let output_schema = self.scanner_output_schema()?; | ||
| Ok(Arc::new(LocalTakeExec::new( | ||
| filter_node, | ||
| Ok(Arc::new(TakeExec::try_new( |
Contributor
There was a problem hiding this comment.
why did we need a separate LocalTake before?
Member
Author
There was a problem hiding this comment.
Was attempted to make it similar to what C++ does, that it takes the same batch from the input BatchRecords, but later found out it is too difficult to implement that in Rust. In the end, LocalTake becomes almost identical to GlobalTake.
| scores, | ||
| )?; | ||
| let batch_with_score = batch | ||
| .try_with_column(ArrowField::new(SCORE_COL, DataType::Float32, false), scores)?; |
Contributor
There was a problem hiding this comment.
what should the score column's field id be? how would we enforce it?
Member
Author
There was a problem hiding this comment.
This is still not clear to me why needs to reinforce column id here.
Not clear to me what bug it triggers, as all python tests / rust tests passed. Do you remember which PR # is the fix? i can look into that as well.
changhiskhan
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix KNNFlat / KNNIndex node output schema.
Add preconditions for KNN nodes to check inputs and parameters.
Removed the hack in scanner to pass ann schema explicitly.