Merged
Conversation
eddyxu
force-pushed
the
lei/refactor_plan
branch
from
d54a930 to
11bbb91
Compare
eddyxu
force-pushed
the
lei/refactor_plan
branch
from
1880c6a to
2fb8a87
Compare
changhiskhan
approved these changes
Mar 24, 2023
| } | ||
|
|
||
| fn get_exec_columns(plan: &dyn ExecutionPlan) -> Vec<String> { | ||
| plan.schema() |
Contributor
There was a problem hiding this comment.
should we make a field_names method in schema?
Member
Author
There was a problem hiding this comment.
This is Arrow schema, guess we can add this method via ArrowSchemaExt.
| vec![] | ||
| }; | ||
| let knn_idx = indices.iter().find(|i| i.fields.contains(&column_id)); | ||
| if let Some(index) = knn_idx { |
Contributor
There was a problem hiding this comment.
is this just copy paste? any changes?
Member
Author
There was a problem hiding this comment.
Moved the filters out, so the filters consolidates with the rest of exec path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #687