Conversation
|
|
||
| Ok(Self { | ||
| inner: Arc::new(LocalFileSystem::new()), | ||
| inner: Arc::new(LocalFileSystem::new_with_prefix(expanded_path.deref())?), |
There was a problem hiding this comment.
This is the biggest change - the path provided by the users will be used as prefix by the LocalFileSystem. The prefix need to exist, so I added logic to create the directory if it does not exist yet.
| use std::path::Prefix; | ||
| use std::path::Prefix::*; | ||
|
|
||
| fn get_path_prefix(path: &StdPath) -> Prefix { |
There was a problem hiding this comment.
Most of the logic here is to get the windows drive letter (C:, D:). There is nothing in this test that is not covered by the other tests, but I'm leaving it to make sure that / and \\ are still working.
| shell: powershell | ||
| run: | | ||
| cd $env:VCPKG_INSTALLATION_ROOT | ||
| git pull |
There was a problem hiding this comment.
GHA has a very old version of vcpkg, so some packages were no longer available. By updating the vcpkg sources in each build we solve this issue, but it may increase the build times since we will build openblas / lapack more often.
gsilvestrin
changed the title
|
|
||
| [target.'cfg(target_os = "windows")'.dependencies] | ||
| openblas-src = { version = "0.10.8", default-features= false, features = ["system"]} | ||
| lapack-src = { version = "0.8", features = ["openblas"] } |
There was a problem hiding this comment.
This is not os-specific dependency?
There was a problem hiding this comment.
We don't need it in the other platforms, and I think you might not need it in windows as well since we are using vcpkg to lookup the packages. I'll try to remove it
| type Matrix = Self; | ||
| type Sigma = Float32Array; | ||
|
|
||
| // FIXME implement svd in windows |
2 participants
Uh oh!
There was an error while loading. Please reload this page.