Skip to content

Fix LanceDataset.to_batches#751

Merged
changhiskhan merged 2 commits intomainfrom
changhiskhan/gh-750
Apr 5, 2023
Merged

Fix LanceDataset.to_batches#751
changhiskhan merged 2 commits intomainfrom
changhiskhan/gh-750

Conversation

@changhiskhan
Copy link
Copy Markdown
Contributor

@changhiskhan changhiskhan commented Apr 5, 2023

Close #750

eddyxu
eddyxu approved these changes Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run black as well?

@changhiskhan
Copy link
Copy Markdown
Contributor Author

changhiskhan commented Apr 5, 2023

Could you run black as well?

there's only an extra newline

@changhiskhan changhiskhan merged commit 3030dba into main Apr 5, 2023
@changhiskhan changhiskhan deleted the changhiskhan/gh-750 branch April 5, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddyxu eddyxu eddyxu approved these changes

+1 more reviewer

@gsilvestrin gsilvestrin gsilvestrin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in to_batches()

3 participants

@changhiskhan @eddyxu @gsilvestrin