fix: treat blob descriptors as opaque projections#7618
Merged
Conversation
github-actions
Bot
added
A-python
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
brendanclement
approved these changes
Jul 3, 2026
jackye1995
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7617.
The issue was caused by unloaded blob descriptor schemas being treated like ordinary V2.0 structs during reader projection validation. Blob descriptor views are backed by a single physical blob column, so the reader should not recurse into descriptor child fields such as
positionandsizewhen consuming projection column indices.This keeps blob and packed-struct fields opaque across file versions and adds regression coverage for descriptor scans, binary blob scans,
take_blobs, andread_blobs.Validation note: Rust formatting, full workspace clippy, and targeted Rust/Python regressions pass.
uv run make lintstill fails on this macOS environment because pyright checks existing TensorFlow imports whiletensorflowis configured as a Linux-only dependency inpython/pyproject.toml.