[Rust] Expose DataFragment as pubilc dataset api.#769
Merged
Conversation
| /// Get fragments. | ||
| /// | ||
| /// If `filter` is provided, only fragments with the given name will be returned. | ||
| pub fn get_fragments(&self) -> Vec<FileFragment> { |
Contributor
There was a problem hiding this comment.
confusing to have both get_fragments and fragments ?
Member
Author
There was a problem hiding this comment.
Yea, so i will refactor it later to remove fragments entirely.
| } | ||
|
|
||
| async fn do_open(&self, paths: &[&str]) -> Result<FileReader> { | ||
| // TODO: support open multiple data failes. |
| offset: None, | ||
| nearest: None, | ||
| with_row_id: false, | ||
| fragment: None, |
Contributor
There was a problem hiding this comment.
what's the purpose of a scanner that only does 1 fragment?
Member
Author
There was a problem hiding this comment.
This is to support pyarrow.dataset.Fragment.to_batch().
So via exposing DataFragment using pyarrow API, users can get a list of Fragments on different machine, and each Fragment can be used as basic unit to read a file, distributedly.
| } | ||
| } | ||
|
|
||
| pub fn from_fragment(dataset: Arc<Dataset>, fragment: Fragment) -> Self { |
changhiskhan
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a
FileFragmentstruct modeled afterpyarrow.dataset.Fragment