Conversation
gsilvestrin
reviewed
Apr 18, 2023
| } | ||
| } | ||
|
|
||
| #[cfg(not(target_arch = "aarch64"))] |
Contributor
There was a problem hiding this comment.
At this point you already know that target_arch != "aarch64", right?
Member
Author
There was a problem hiding this comment.
This is making compiler happy. on aarch64, compiler will think this is dead code because it never reaches here.
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
Contributor
There was a problem hiding this comment.
should we add tests to the aarch64 / x86_64 modules?
gsilvestrin
approved these changes
Apr 18, 2023
Contributor
gsilvestrin
left a comment
gsilvestrin
left a comment
There was a problem hiding this comment.
LGTM, some small comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cosinedistance tolinalgmodule.x86_64::avxandaarch64::neonmodules ,and prepare the code to accept data types other thanf32. Also support dynamical CPU feature detection.