Skip to content

add support for aws profile#807

Merged
changhiskhan merged 1 commit intolance-format:mainfrom
Renkai:add_profile_support
Apr 26, 2023
Merged

add support for aws profile#807
changhiskhan merged 1 commit intolance-format:mainfrom
Renkai:add_profile_support

Conversation

@Renkai
Copy link
Copy Markdown
Contributor

@Renkai Renkai commented Apr 25, 2023

This closes #806

@changhiskhan
Copy link
Copy Markdown
Contributor

is this for recognizing the AWS_PROFILE envvar? if so, pretty sure that already works? How did you test before/after the fix?

@Renkai
Copy link
Copy Markdown
Contributor Author

Renkai commented Apr 25, 2023

Yes, I have tested it locally. Before I add this tag the error information is IO("Generic S3 error: Profile support requires aws_profile feature").
With the flag it put data successfully.
BTW, aws_profile is a superset of [aws,aws-config,aws-types,aws-credential-types]

https://docs.rs/crate/object_store/latest/features

Copy link
Copy Markdown
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This looks fine. we'll figure out the windows CI issue later.

@changhiskhan changhiskhan merged commit 4e4dcb0 into lance-format:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support aws profile

2 participants