Fix cosine similarity when missing simd alignment#808
Merged
changhiskhan merged 3 commits intomainfrom Apr 25, 2023
Merged
Conversation
changhiskhan
force-pushed
the
changhiskhan/cosine-bug
branch
3 times, most recently
from
4a3b347 to
95ea462
Compare
eddyxu
reviewed
Apr 25, 2023
| } | ||
|
|
||
| #[inline] | ||
| fn dotprod_scalar<T: Real + Sum>(x: &[T], y: &[T]) -> T { |
Member
There was a problem hiding this comment.
Lets call https://github.com/eto-ai/lance/blob/main/rust/src/linalg/dot.rs ?
Will add SIMD for dot product later.
| mod x86_64 { | ||
| use super::dotprod_scalar; | ||
| use super::sq_scalar; | ||
| use std::arch::x86_64::*; |
Member
There was a problem hiding this comment.
sort import by sections? std / third party / lance with a blank line in between.
| } | ||
|
|
||
| #[inline] | ||
| fn sq_scalar<T: Real + Sum>(y: &[T]) -> T { |
Member
There was a problem hiding this comment.
Extract this to a new routine? or just use normalize().pow(2)?
Member
There was a problem hiding this comment.
changhiskhan
force-pushed
the
changhiskhan/cosine-bug
branch
from
95ea462 to
f107814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also a bunch of formatting fixes