Conversation
eddyxu
approved these changes
Apr 27, 2023
Member
eddyxu
left a comment
eddyxu
left a comment
There was a problem hiding this comment.
Seems fine to me, other than a few concept changes , i assume that is what is done in Arrow
| for idx in chosen.iter() { | ||
| let s = self.data.slice(idx * dim, dim); | ||
| builder.append_slice(as_primitive_array::<Float32Type>(s.as_ref()).values()); | ||
| builder.append_slice(s.values()); |
Contributor
Author
There was a problem hiding this comment.
yeah, must be part of the effort towards arrow-rs arrow2 merging?
| vec![27.46873242, 22.64318501, 8.55838823, 5.9857232, 2.01489966].as_slice(), | ||
| epsilon = 0.0001, | ||
| ); | ||
| u.data() |
Member
There was a problem hiding this comment.
why can we just use slice comparision here?
Contributor
Author
There was a problem hiding this comment.
complains about ScalarBuffe not having AbsDiffEq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't go to 38 yet even though it's out. Datafusion is on 37 latest.
We need 37 for Will's fix for handling schema metadata.