Merged
Conversation
eddyxu
commented
Apr 29, 2023
| } | ||
|
|
||
| /// Intersection between two [`Schema`]. | ||
| pub fn intersection(&self, other: &Self) -> Result<Self> { |
Member
Author
There was a problem hiding this comment.
This is what is added in this PR.
Contributor
There was a problem hiding this comment.
so intersection only happens at the top level then? do we need to also look at child fields?
| /// Lance Schema Field | ||
| /// | ||
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct Field { |
Contributor
There was a problem hiding this comment.
Is this just a straight move from datatypes.rs or are there code changes too?
| } | ||
|
|
||
| /// Intersection between two [`Schema`]. | ||
| pub fn intersection(&self, other: &Self) -> Result<Self> { |
Contributor
There was a problem hiding this comment.
so intersection only happens at the top level then? do we need to also look at child fields?
changhiskhan
approved these changes
Apr 29, 2023
Member
Author
it does nested call into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datatypemodule to separate files.Fragmentto decide which data file contains the columns to read.