Conversation
eddyxu
requested review from
changhiskhan and
gsilvestrin
and removed request for
gsilvestrin
changhiskhan
approved these changes
May 2, 2023
| let arrs: Result<Vec<_>> = batch | ||
| pub async fn write(&mut self, batches: &[&RecordBatch]) -> Result<()> { | ||
| // Copy a list of fields to avoid borrow checker error. | ||
| let fields = self |
Contributor
There was a problem hiding this comment.
I don't understand why tho the code doesn't seem to modify the fields?
Member
Author
There was a problem hiding this comment.
Oh, so self.schema has a immuntable reference to self, but later it needs mutable reference self to call self.write_array
Member
Author
There was a problem hiding this comment.
Leave a comment here, in case some Rust guru knows how to do it better later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove lifetime from
FileWriter, because thepyo3can not hold a struct with lifetime