Merged
Conversation
eddyxu
reviewed
May 9, 2023
| .then(|(batch, schema)| async move { | ||
| let batch = batch?; | ||
| batch.project_by_schema(schema.as_ref()) | ||
| let output_batch = batch.project_by_schema(schema.as_ref()); |
Member
There was a problem hiding this comment.
this was for debugging? can revert it back?
| .take_rows(row_ids.values(), &extra) | ||
| .await? | ||
| .merge(&batch)? | ||
| batch.merge(&dataset.take_rows(row_ids.values(), &extra).await?)? |
Member
There was a problem hiding this comment.
what is the purpose to change the order of merge?
changhiskhan
force-pushed
the
changhiskhan/filter-nested-field
branch
from
ca8927b to
0dc7382
Compare
eddyxu
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #836 , just split out for easier review.
Basically in the Take node, we do a.merge(b) for schema but b.merge(a) for RecordBatch.
So then in Projection, we get a schema that has struct_field with subfields f1 and f2, but the data has struct_field with subfields f2 and f1.