feat(mcp): nbox_get accepts ip_address as an alias for ip#46
Merged
Conversation
nbox_search returns kind="ip_address" (ObjectKind::IpAddress) while nbox_get canonically uses "ip" — the only kind whose spelling differs between the two enums (route_target/ip_range/etc. already match). An agent chaining search → get had to translate it. Rather than change the pinned search output (a CLI --json/MCP contract), make GetKind accept ip_address as a non-breaking alias: serde alias on the tool arg + from_str for nbox://ip_address/<ref>. Documented in AGENTS.md / docs/MCP.md. Test covers both the tool-arg and resource-URI paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the MCP search→get kind asymmetry (review Tier 1 #1).
nbox_searchreturnskind = "ip_address";nbox_getcanonically usesip. I diffed the two enums — that's the only divergence (route_target/ip_range/etc. already match). Rather than rename the pinned search output (a CLI--json/MCP contract break),GetKindnow acceptsip_addressas a non-breaking alias forip:#[serde(alias = "ip_address")]on the tool-arg pathfrom_strfallback fornbox://ip_address/<ref>So an agent can chain search → get (and the resource URI) without translating the kind. Documented in AGENTS.md / docs/MCP.md; test covers both paths. Gate green (767 lib tests).