Add animated replay mode with speed control #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Record probe events during trace (offset_ms, ttl, response/timeout) - Add ProbeEvent/ProbeOutcome structs to session.rs - Session JSON now includes events array (backward compatible) - Add --animate flag for replay mode - Animated replay shows hop-by-hop discovery in TUI - Space to pause/resume replay - Increase TUI refresh to 60fps for responsive updates (#17) - Graceful fallback for old sessions without events
- Add hop.record_sent() so hops appear in TUI (was filtering h.sent > 0) - Set dest_ttl when destination reached during replay - Add #[allow(clippy::too_many_arguments)] to run_tui
- Add --speed flag for replay speed control (default 10x) - Use monotonic clock (Instant) for event offsets to prevent clock jumps - Fix pause/resume to reset start time correctly - Add seq and flow_id to ProbeEvent for full probe correlation - Add LateReply event type for responses arriving after timeout - Fix borrow checker issues with offset_ms calculation - Update docs: README, FEATURES.md, SCRIPTING.md, CHANGELOG, ROADMAP
Consistent with the TUI status bar legend which shows 'p pause'.
- Fix unreachable 'p' pattern: route to replay or live pause based on mode - Fix LateReply double-counting sent probes and total_sent - Fix resume timing: track elapsed at pause instead of using next event offset - Fix multi-flow replay: use correct response recording based on flow count - Sort events by offset_ms in ReplayState::new to prevent stalled replay - Uncheck progress indicator in ROADMAP (not implemented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--animateflag for replay mode that shows probe-by-probe discovery as it happened--speedflag to control replay speed (default 10x, use 1.0 for real-time)Technical Changes
seq,flow_idfor full probe correlationstd::time::Instantinstead of wall clock for event offsets (prevents clock jump issues)late_replyeventsUsage
Closes #9
Test plan
cargo testpassescargo clippyclean--json, replay with--animate--speedaffects playback rate