Update dependency verification doc, pull out snippets#196
Conversation
| description = "Add your description here" | ||
| readme = "README.md" | ||
| requires-python = ">=3.13" | ||
| requires-python = ">=3.12,<3.14" |
There was a problem hiding this comment.
Geneva needs 3.12 :(
There was a problem hiding this comment.
I'm adding 3.13 right now.
There was a problem hiding this comment.
There was a problem hiding this comment.
and actually has been supporting 3.10
but this looks good to me.
There was a problem hiding this comment.
woohoo! ok, sounds good.
| <CodeGroup> | ||
| ```python Python icon="python" | ||
| from geneva.manifest.builder import GenevaManifestBuilder | ||
| from geneva.manifest.builder import PipManifestBuilder |
There was a problem hiding this comment.
This little bit is still untested because the env_vars method was just added today; once it's in the next release we can pull it out into a snippet as well.
There was a problem hiding this comment.
both of these apis are valid but pip is preferred.
There was a problem hiding this comment.
Nope, GenevaManifestBuilder doesn't exist anymore, that's what got me started on this whole thing anyway 😆
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
| @@ -0,0 +1,16 @@ | |||
| {/* Auto-generated by scripts/mdx_snippets_gen.py. Do not edit manually. */} | |||
|
|
|||
| export const PyCondaManifestInline = "from geneva.manifest.builder import CondaManifestBuilder\n\nmanifest = (\n CondaManifestBuilder.create(\"my-manifest\")\n .conda({\n \"channels\": [\"conda-forge\"],\n \"dependencies\": [\n \"python=3.10\",\n \"ffmpeg<8\",\n \"torchvision=0.22.1\",\n ],\n })\n .build()\n)\n"; | |||
There was a problem hiding this comment.
nit:
using triple quotes """" or ''' would allow this to be formatted and more readable.
jmhsieh
left a comment
jmhsieh
left a comment
There was a problem hiding this comment.
docs content looks good to me.
2 participants
Question for @prrao87, to double check: when I want to update one of these snippets in the future, I just update the test, right? and then the mdx_snippets_gen.py will pull that updated code into the real mdx file?