Add summary tables for index and quantization types + FTS OSS Example #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-wang-lancedb
changed the title
Contributor
Author
|
Need to make FTS OSS Example testable snippet |
…vector-index-page
…vector-index-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add summary table for index, + separate table for quantization for clarity (as opposed to new row for IvfPq, IvfRq, IvfFlat, etc. Just have one row IVF one row HNSW, and diff table for quantization methods)
#13
Reference existing bindings via:
https://github.com/lancedb/lancedb/blob/main/python/python/lancedb/index.py#L696
https://github.com/lancedb/lancedb/blob/main/rust/lancedb/src/index.rs#L279
https://github.com/lancedb/lancedb/blob/main/nodejs/lancedb/indices.ts#L563
Also added OSS FTS Example (use create_index with FTS instead of create_fts_index for AsyncTable). Added as expandable under note, to not clutter page. #19