Make proxy follow redirects server-side instead of passing to the browser#3
Open
lxpollitt wants to merge 1 commit intolanceewing:masterfrom
Open
Make proxy follow redirects server-side instead of passing to the browser#3lxpollitt wants to merge 1 commit intolanceewing:masterfrom
lxpollitt wants to merge 1 commit intolanceewing:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Changes fetch(request) to
fetch(request, { redirect: 'follow' })so the Cloudflare Worker follows redirects server-side rather than passing them through to the browser.See the linked issue for full diagnosis, a failing example, a working example, and a discussion of the bandwidth trade-off.
Tested locally using Wrangler — before the fix the proxy returns a 302 to the browser; after the fix it returns a 200 with the proxy's own CORS headers applied.