feat: promote npm edge tag to latest when prerelease is promoted#57
Merged
Conversation
Adds a 'released' trigger to the release workflow with a lightweight 'promote' job that runs npm dist-tag to move 'latest' to the current version when a prerelease is promoted to a full release. The existing publish pipeline remains gated to 'published' events only.
❌ Deploy Preview for lando-apache failed. Why did it fail? →
|
| echo "::notice title=Promoted $VERSION to latest::The latest tag now points to $VERSION (was edge-only)" | ||
| env: | ||
| TAG_NAME: ${{ github.event.release.tag_name }} | ||
| NODE_AUTH_TOKEN: ${{secrets.NPM_DEPLOY_TOKEN}} |
There was a problem hiding this comment.
Race condition causes promote job to fail on non-prerelease
Medium Severity
When a fresh non-prerelease is published, GitHub fires both published and released as separate workflow runs. The lightweight promote job (~15s) will execute npm dist-tag add well before the deploy job finishes installing, linting, testing, and publishing the package. This causes promote to fail because the version doesn't exist on npm yet. While the deploy job correctly sets latest for non-prereleases, every fresh non-prerelease publish will produce a failed workflow run in the GitHub Actions UI. Since these are separate runs, needs can't create a dependency between them.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
When a release is published as a prerelease, it gets tagged as
edgeon npm. Later, when the release is promoted to a full release in GitHub, the npmlatesttag doesn't update because the workflow only triggered onpublished.Solution
releasedto the release workflow trigger typespromotejob that only runsnpm dist-tag add latest— no install, no lint, no tests, no re-publishreleasedevent (when a prerelease is promoted to full release)deployjob is now explicitly gated topublishedevents only (no behavior change)TAG_NAMEenv var instead of direct interpolation to prevent script injectionFlow
edgetag (unchanged)promotejob runs, pointslatestto that version (~15s)The
dist-tag addcommand is idempotent, so if bothpublishedandreleasedfire on a fresh non-prerelease publish, the redundant promote is harmless.Note
Low Risk
CI-only change that adjusts workflow triggers and updates npm dist-tags; risk is limited to release automation behavior and requires correct
NPM_DEPLOY_TOKENpermissions.Overview
Updates the
release.ymlGitHub Actions workflow to also trigger onreleasedevents (in addition topublished).Adds a new
promotejob that runs only onreleasedto retag the just-promoted version as npmlatestvianpm dist-tag add, while gating the existing publish pipeline (deploy) to run only onpublishedevents.Written by Cursor Bugbot for commit c435d20. This will update automatically on new commits. Configure here.