Add database client auto-detection and version matching

[AaronFeledy]

Summary

Addresses MariaDB/MySQL client compatibility issues (lando/lando#3833) by detecting database services and installing matching clients for PHP 8.3+.

Changes

• Auto-detection: Scans services for mysql:X.X or mariadb:X.X and installs the appropriate client
• db_client config option: auto (default), false, or explicit type:version
• Pre-downloaded MySQL clients: Both 8.0 and 8.4 binaries included in images
• MariaDB wrappers: Creates mysql → mariadb wrappers to avoid deprecation warnings
• Compatibility configs: Sets disable-ssl-verify-server-cert and skip-column-statistics

Version Mapping

Database Version	Client Used
MySQL 8.3, 8.4	MySQL 8.4 client
MySQL 5.7, 8.0, 8.1, 8.2	MySQL 8.0 client
MariaDB 10.x, 11.x	MariaDB client with wrappers

Testing

services:
  appserver:
    type: php:8.4
  database:
    type: mysql:8.4  # Client auto-detected

See examples/db-client/ for test scenarios.

Notes

• Only applies to PHP 8.3+ (older versions keep default mariadb-client)
• Requires image rebuild to include pre-downloaded MySQL binaries

Resolves #167,

---

Note

Medium Risk
Touches service build-step generation and Docker image contents; mistakes could break mysql/mysqldump availability or alter client behavior for PHP 8.3+ containers.

Overview
Adds database client auto-detection and installation for PHP 8.3+ services. builders/php.js now introduces a db_client option (default auto) that scans app services for mysql:*/mariadb:* and injects a root build step to install a matching client, with false to opt out or an explicit type:version override.

To support version-matched installs, PHP 8.3–8.5 image Dockerfiles now bundle pre-fetched MySQL 8.0 and 8.4 client binaries, and new helper scripts (install-db-client.sh, mysql-client-install.sh, mariadb-compat-install.sh) switch clients via symlinks/wrappers and write compatibility config. Docs and examples are updated, and example fixtures bump image tags from -6 to -7 plus a new examples/db-client scenario.

^{Written by Cursor Bugbot for commit 9b8084c. This will update automatically on new commits. Configure here.}

[netlify]

✅ Deploy Preview for lando-php ready!

Name	Link
🔨 Latest commit	9b8084c
🔍 Latest deploy log	https://app.netlify.com/projects/lando-php/deploys/6995313de591d200086c06b3
😎 Deploy Preview	https://deploy-preview-212--lando-php.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 84 (🟢 up 16 from production) Accessibility: 98 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cursor]

Bugbot Autofix prepared fixes for 2 of the 2 bugs found in the latest run.

• ✅ Fixed: MariaDB wrapper script generates wrong command names
  • Added hyphen separator in command name generation to produce correct MariaDB binary names like mariadb-dump instead of mariadbdump.
• ✅ Fixed: Auto-detection returns wrong client in multi-database test
  • Added explicit db_client: mysql:8.4 to php-mysql84 service to ensure correct client selection instead of relying on global auto-detection.

Or push these changes by commenting:

@cursor push a328c4043c

Preview (a328c4043c)

diff --git a/examples/db-client/.lando.yml b/examples/db-client/.lando.yml
--- a/examples/db-client/.lando.yml
+++ b/examples/db-client/.lando.yml
@@ -5,6 +5,7 @@
   php-mysql84:
     type: php:8.4
     via: cli
+    db_client: mysql:8.4
 
   mysql84:
     type: mysql:8.4

diff --git a/scripts/mariadb-compat-install.sh b/scripts/mariadb-compat-install.sh
--- a/scripts/mariadb-compat-install.sh
+++ b/scripts/mariadb-compat-install.sh
@@ -9,7 +9,8 @@
 
 # Create wrapper scripts for each mysql* command that maps to mariadb* equivalent
 for cmd in mysql mysqldump mysqladmin mysqlcheck mysqlimport mysqlshow; do
-  mariadb_cmd="mariadb${cmd#mysql}"
+  suffix="${cmd#mysql}"
+  mariadb_cmd="mariadb${suffix:+-}${suffix}"
 
   if command -v "$mariadb_cmd" &> /dev/null; then
     cat > "/usr/local/bin/$cmd" << EOF

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before Autofix could start.}

[cursor]

MariaDB config breaks mysqldump with unknown option

High Severity

The [mysqldump] section containing skip-column-statistics is written to lando.cnf by the MariaDB compat script. MariaDB's mariadb-dump tool reads this section (for backward compatibility with [mysqldump]) but does not recognize skip-column-statistics, which is a MySQL 8.0-only option. This causes mariadb-dump (and the mysqldump wrapper) to fail with an "unknown variable" error, breaking mysqldump for all MariaDB setups — the exact scenario the PR aims to fix.

 

[cursor]

Copied MySQL binaries lack required shared library dependencies

High Severity

The COPY --from=mysql-client-80 and COPY --from=mysql-client-84 directives copy only the MySQL client binaries without their required shared libraries (notably libmysqlclient.so.21/.so.22). These binaries are dynamically linked and will fail at runtime with "cannot open shared object file" errors. The PHP image only has MariaDB's libmariadb.so.3 (from mariadb-client), which is not ABI-compatible with MySQL's libmysqlclient. The mysql-client-install.sh warning fallback (mysql --version || echo ...) masks this during build, but the feature is completely non-functional at runtime.

Additional Locations (2)

• images/8.3-fpm/Dockerfile#L60-L66
• scripts/mysql-client-install.sh#L33-L37