remove redundant codegroup for langsmith quickstart #1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Mintlify preview ID generated: preview-mdrxyl-1762189387-e321a5d |
katmayb
approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies environment configuration sections by removing redundant code blocks and standardizing documentation format. The changes affect documentation for tracing with LangChain and LangGraph.
- Removes duplicate
CodeGroupsections for Python and TypeScript bash commands - Consolidates environment variable configuration into single bash code blocks with
wrapattribute - Adds indentation to content within
<Info>components
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/langsmith/trace-with-langgraph.mdx | Simplifies environment configuration sections (both "With LangChain" and "Without LangChain" sections) by removing duplicate bash code blocks and adding indentation to Info component content |
| src/langsmith/trace-with-langchain.mdx | Removes duplicate bash code blocks in environment configuration and adds indentation to Info component content |
Comment on lines
51
to
61
| <Info> | ||
| If you are using LangChain.js with LangSmith and are not in a serverless environment, we also recommend setting the following explicitly to reduce latency: | ||
| If you are using LangChain.js with LangSmith and are not in a serverless environment, we also recommend setting the following explicitly to reduce latency: | ||
|
|
||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=true` | ||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=true` | ||
|
|
||
| If you are in a serverless environment, we recommend setting the reverse to allow tracing to finish before your function ends: | ||
| If you are in a serverless environment, we recommend setting the reverse to allow tracing to finish before your function ends: | ||
|
|
||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=false` | ||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=false` | ||
|
|
||
| See [this LangChain.js guide](https://js.langchain.com/docs/how_to/callbacks_serverless) for more information. | ||
| See [this LangChain.js guide](https://js.langchain.com/docs/how_to/callbacks_serverless) for more information. | ||
| </Info> |
There was a problem hiding this comment.
The content within the <Info> component should not be indented. This is inconsistent with the established pattern used throughout the codebase (see src/langsmith/administration-overview.mdx, src/langsmith/env-var.mdx, src/langsmith/multi-turn-simulation.mdx, etc.). Remove the 4-space indentation from all lines within the <Info> tags.
Comment on lines
240
to
250
| <Info> | ||
| If you are using LangChain.js with LangSmith and are not in a serverless environment, we also recommend setting the following explicitly to reduce latency: | ||
| If you are using LangChain.js with LangSmith and are not in a serverless environment, we also recommend setting the following explicitly to reduce latency: | ||
|
|
||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=true` | ||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=true` | ||
|
|
||
| If you are in a serverless environment, we recommend setting the reverse to allow tracing to finish before your function ends: | ||
| If you are in a serverless environment, we recommend setting the reverse to allow tracing to finish before your function ends: | ||
|
|
||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=false` | ||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=false` | ||
|
|
||
| See [this LangChain.js guide](https://js.langchain.com/docs/how_to/callbacks_serverless) for more information. | ||
| See [this LangChain.js guide](https://js.langchain.com/docs/how_to/callbacks_serverless) for more information. | ||
| </Info> |
There was a problem hiding this comment.
The content within the <Info> component should not be indented. This is inconsistent with the established pattern used throughout the codebase. Remove the 4-space indentation from all lines within the <Info> tags.
Comment on lines
47
to
55
| <Info> | ||
| If you are using LangChain.js with LangSmith and are not in a serverless environment, we also recommend setting the following explicitly to reduce latency: | ||
|
|
||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=true` | ||
| If you are using LangChain.js with LangSmith and are not in a serverless environment, we also recommend setting the following explicitly to reduce latency: | ||
|
|
||
| If you are in a serverless environment, we recommend setting the reverse to allow tracing to finish before your function ends: | ||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=true` | ||
|
|
||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=false` | ||
| If you are in a serverless environment, we recommend setting the reverse to allow tracing to finish before your function ends: | ||
|
|
||
| `export LANGCHAIN_CALLBACKS_BACKGROUND=false` | ||
| </Info> |
There was a problem hiding this comment.
The content within the <Info> component should not be indented. This is inconsistent with the established pattern used throughout the codebase. Remove the 4-space indentation from all lines within the <Info> tags.
mdrxy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content is identical