Skip to content

Conversation

@bwhiting2356
Copy link
Contributor

@bwhiting2356 bwhiting2356 commented Nov 25, 2025

Overview

Fixing two issues in this section of the docs: an unused model var and type errors with tool Runtime

Type of change

  • In the "Full example code" section, model was defined but never used. Now we pass in the model object instead of the string.
  • Fixing type errors from Runtime when we defined getUserLocation, both in "Full example code" and the earlier snippet.
  • Using object shorthand properties consistently

Checklist

  • I have read the contributing guidelines
  • I have tested my changes locally using docs dev
  • All code examples have been tested and work correctly
  • I have used root relative paths for internal links
  • I have updated navigation in src/docs.json if needed

(Internal team members only / optional): Create a preview deployment as necessary using the Create Preview Branch workflow

Additional notes

@github-actions github-actions bot added langchain For docs changes to LangChain oss labels Nov 25, 2025
@github-actions
Copy link
Contributor

Mintlify preview ID generated: preview-brenda-1764048328-d21d30f

@github-actions
Copy link
Contributor

Mintlify preview ID generated: preview-brenda-1764048940-aac73d5

@bwhiting2356 bwhiting2356 marked this pull request as ready for review November 25, 2025 05:37
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit fe91323 into main Nov 25, 2025
15 checks passed
@christian-bromann christian-bromann deleted the brendan/js-docs-update branch November 25, 2025 05:45
@bwhiting2356 bwhiting2356 mentioned this pull request Nov 25, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

langchain For docs changes to LangChain oss

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants