Use logger.exception to log errors inside exception handlers and avoid logging from the root logger
#364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid logging from the root logger
murilosimao
pushed a commit
to murilosimao/langchain-aws
that referenced
this pull request
Oct 29, 2025
…oid logging from the root logger (langchain-ai#364) ## Rationale - Not using the root logger lets the end user better control logging for specific packages and modules, e.g. by configuring `langchain_aws.llms.bedrock` to log at the `ERROR` level, but `langchain_aws.llms.bedrock` at the `DEBUG` level. - Using `logger.exception` adds exception info to the [log record](https://docs.python.org/3/library/logging.html#logrecord-attributes). This is particularly useful if you want to use a library like [python-json-logger](https://pypi.org/project/python-json-logger/) or [structlog](https://github.com/hynek/structlog), where the exception info could be nicely formatted into an array/object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
langchain_aws.llmsto log at theERRORlevel, butlangchain_aws.llms.bedrockat theDEBUGlevel.logger.exceptionadds exception info to the log record. This is particularly useful if you want to use a library like python-json-logger or structlog, where the exception info could be nicely formatted into an array/object.