chore: adds support for PineconeGRPC client #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bruvduroiu ! I attempted to do this in my fork but couldn't complete it (primarily the integration tests) due to a lack of time. Feel free to use any of my code if it helps. https://github.com/asvishnyakov/langchain/tree/pinecone-grpc-async/libs/partners/pinecone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In high-throughput situation, Pinecone's gRPC client is able to handle large amounts of parallel requests through multiplexing.
Implementation
To keep UX consistent, considering a
use_grpcflag for thePineconeVectorStore, but equally could create aPineconeGRPCVectorStoreto maintain consistency with the Pinecone SDK.Closes #2