-
Notifications
You must be signed in to change notification settings - Fork 20.5k
community: Fix retrieval node objects #30444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ccurme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that demonstrates what is being fixed? I assume the string representation for Node is nonsensical? This is a change in the interface so we need to demonstrate that this is a bug fix (i.e., the existing behavior is not useful).
You're right. This is a bug fix for the string representation of nodes. In other graph providers, it is implemented in the graph file (see the image below). I believe the correct place for this is when the user needs the query for context. Do you agree? |
|
@galshubeli For testing, we'd ideally add a unit test into a (new) file here. It should test what context is being supplied to a (fake) chat model. It looks like we return the context in intermediate steps, so you should be able to access that in the test. The test should fail for the implementation that's currently on |
ccurme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galshubeli we've now moved langchain-community into a standalone repo. Would you mind opening your PR there, along with a unit test?

If no one reviews your PR within a few days, please @-mention one of baskaryan, eyurtsev, ccurme, vbarda, hwchase17.