Skip to content

Conversation

@sydney-runkle
Copy link
Collaborator

@sydney-runkle sydney-runkle commented Dec 3, 2025

Fixes #34169

Patching logic introduced in #33999

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025

CodSpeed Performance Report

Merging #34185 will degrade performances by 23%

Comparing sr/fix-tool-call-id-bug (3733136) with master (b7091d3)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 2 (👁 2) regressions
✅ 11 untouched
⏩ 21 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
👁 WallTime test_async_callbacks_in_sync 18.6 ms 24.1 ms -23%
👁 WallTime test_import_time[InMemoryVectorStore] 551 ms 623.6 ms -11.64%

Footnotes

  1. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions github-actions bot added fix and removed fix labels Dec 3, 2025
@sydney-runkle sydney-runkle merged commit 8e3ca21 into master Dec 3, 2025
175 of 177 checks passed
@sydney-runkle sydney-runkle deleted the sr/fix-tool-call-id-bug branch December 3, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Related to the package `langchain-core` fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[langchan-core] Breaking change: Tool with argument tool_call_id forces invoke to use different call pattern

3 participants