Skip to content

[RFC] Question of Tooling Consistency Check Between Agent<>AgentExecutor #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[RFC] Question of Tooling Consistency Check Between Agent<>AgentExecutor #4022

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3760b8
question of tooling validation in agent
skcoirz May 3, 2023
55a4734
format
skcoirz May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions langchain/agents/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,12 +629,15 @@ def validate_tools(cls, values: Dict) -> Dict:
agent = values["agent"]
tools = values["tools"]
allowed_tools = agent.get_allowed_tools()
if allowed_tools is not None:
if set(allowed_tools) != set([tool.name for tool in tools]):
raise ValueError(
f"Allowed tools ({allowed_tools}) different than "
f"provided tools ({[tool.name for tool in tools]})"
)
if allowed_tools is None and len(tools) == 0:
return values
if allowed_tools is None and len(tools) != 0:
raise ValueError("Tools provided but no tool defined in Agent.")
if set(allowed_tools) != set([tool.name for tool in tools]):
raise ValueError(
f"Allowed tools ({allowed_tools}) different than "
f"provided tools ({[tool.name for tool in tools]})"
)
return values

@root_validator()
Expand Down