refactor(sandbox): use SDK runtime helpers#106
Merged
Mukil Loganathan (langchain-infra) merged 8 commits intoMay 6, 2026
Conversation
Mukil Loganathan (langchain-infra)
changed the title
Ramon Nogueira (ramon-langchain)
approved these changes
May 6, 2026
Mukil Loganathan (langchain-infra)
merged commit 3d3feb3
into
main
10 of 11 checks passed
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+85
to
89
| handle, err = client.SDK.Sandboxes.Boxes.StartCommandWithCallbacks(ctx, name, params, callbacks) | ||
| close(handleReady) | ||
| if err != nil { | ||
| return fmt.Errorf("starting console: %w", err) | ||
| } |
There was a problem hiding this comment.
🟡 Nil handle dereference if SDK callback fires after failed StartCommandWithCallbacks
In sandbox_console.go, close(handleReady) is called unconditionally after StartCommandWithCallbacks returns, before the error check. If StartCommandWithCallbacks returns an error, handle is nil. Any OnSSHAgentData callback goroutine waiting on <-handleReady would unblock and call agent.HandleData(nil, channelID, data). When a.sock != "" (i.e., --forward-ssh-agent was requested), HandleData at sandbox_console.go:182 starts readResponses(nil, ...), which calls handle.SendSSHAgentData(...) and handle.CloseSSHAgentChannel(...) on a nil pointer, causing a panic.
Suggested change
| handle, err = client.SDK.Sandboxes.Boxes.StartCommandWithCallbacks(ctx, name, params, callbacks) | |
| close(handleReady) | |
| if err != nil { | |
| return fmt.Errorf("starting console: %w", err) | |
| } | |
| handle, err = client.SDK.Sandboxes.Boxes.StartCommandWithCallbacks(ctx, name, params, callbacks) | |
| if err != nil { | |
| close(handleReady) | |
| return fmt.Errorf("starting console: %w", err) | |
| } | |
| close(handleReady) |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors sandbox runtime paths to use Go SDK helpers instead of carrying duplicate CLI implementations for command execution, console WebSockets, and tunneling.
What changed
Dependency
Test plan