Delete knowledge#44
Merged
deon-sanchez merged 14 commits intomainfrom Sep 18, 2025
Merged
Conversation
- Added a new `DeleteConfirmationDialog` component for confirming deletions. - Updated `KnowledgeDropdown` to include a loading state and improved user feedback during file operations. - Enhanced the search page to support bulk deletion of documents with confirmation dialog. - Integrated event dispatching for knowledge updates after file operations. - Refactored various components for better readability and maintainability.
…lete-knowledge
deon-sanchez
force-pushed
the
delete-knowledge
branch
from
b0a48c7 to
33cb18e
Compare
…lete-knowledge
- Added a delete confirmation dialog to the KnowledgeActionsDropdown component. - Integrated useDeleteDocument mutation for handling document deletion. - Updated the dropdown to pass the filename prop for targeted deletions. - Enhanced user feedback with success and error messages upon deletion.
- Implemented bulk selection and deletion functionality in the Knowledge page. - Added a confirmation dialog for bulk deletions, providing user feedback on success or failure. - Updated AgGrid configuration to support multiple row selection and checkbox functionality. - Styled checkboxes for better visibility and user experience. - Refactored related components to accommodate new bulk actions.
- Removed the clear selection functionality and associated UI elements from the SearchPage component. - Simplified the bulk actions bar by integrating a delete button and a sync button with alert functionality. - Adjusted button styles for consistency and improved user experience. - Enhanced the search input area for better accessibility and usability.
- Updated the file selection UI to allow clicking on file names for selection, enhancing user interaction. - Changed AgGrid configuration to enable row selection with clicks, improving usability. - Removed unnecessary row click event handling to streamline the selection process.
…lete-knowledge
- Added TODO comments for implementing rename and sync functionalities in the KnowledgeActionsDropdown. - Adjusted column definitions in the SearchPage component to improve layout with flex and minWidth properties. - Commented out the sync button in the SearchPage for future implementation, enhancing code clarity.
- Introduced a new ChunksPage component to display chunks of a selected file, enhancing the knowledge management functionality. - Updated the SearchPage component to navigate to the ChunksPage when a file is selected, improving user flow. - Removed the previous file selection logic and integrated a more streamlined approach for chunk display. - Enhanced UI elements for better user experience and accessibility.
…lete-knowledge
mfortman11
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the frontend, focusing on enhancing user experience and robustness in file uploads, cloud connector navigation, and input handling. The main changes include improved loading and error states in the
KnowledgeDropdowncomponent, a new reusable confirmation dialog, and more resilient handling of API responses.User Experience & Feedback Improvements:
KnowledgeDropdowncomponent, including a spinner and context-aware button text during uploads, folder/S3 processing, and cloud connector navigation. This prevents user actions during ongoing operations and improves clarity. [1] [2] [3]knowledgeUpdatedevent to trigger refreshes after uploads or ingestion, centralizing refresh logic and reducing unnecessary queries. [1] [2] [3] [4] [5] [6]Robustness & Error Handling:
Component & Code Quality Improvements:
DeleteConfirmationDialogcomponent for consistent confirmation dialogs across the app.Inputcomponent for better style consistency and code readability, including handling of custom class names and placeholder visibility. [1] [2] [3]