Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Dec 8, 2024

Important

Passes timeout parameter to FernLangfuse in langfuse/client.py to handle API request timeouts.

  • Behavior:
    • Passes timeout parameter to FernLangfuse in langfuse/client.py to handle API request timeouts.
  • Misc:
    • No other changes or refactoring were made.

This description was created by Ellipsis for 05d7da2. It will automatically update as commits are pushed.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

Added timeout parameter configuration to the Langfuse Python client for customizable request timeouts.

  • Added optional timeout parameter in langfuse/client.py that propagates to the underlying FernLangfuse client
  • Default timeout remains at 60 seconds when not specified
  • Maintains backward compatibility with existing client usage

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp enabled auto-merge (squash) December 8, 2024 11:17
@hassiebp hassiebp merged commit 39e226f into main Dec 8, 2024
9 of 10 checks passed
@hassiebp hassiebp deleted the fix-pass-timeout-to-fernlangfuse branch December 8, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Python SDK calls to get_prompt are not using a default timeout and connections aren't closed.

2 participants