Merged
Conversation
|
@claude review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c15573752a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv_buildlangfuse/version.pyfile with metadata-driven package version lookupWhy
This removes Poetry-specific tooling from local development and CI/CD, standardizes the project on uv, and aligns packaging, locking, versioning, and publishing around a single toolchain.
Developer impact
uv syncinstead ofpoetry installuv run ...for linting, type checking, tests, docs, and pre-commituv run --group docs ...uv version,uv build --no-sources, anduv publishNotes
openairemains out of published package metadata and is still a separately installed integration dependencypoetry.lock, addsuv.lock, and updates Dependabot to theuvecosystemlangfuse/apifiles from Ruff hooks to match the repo's existing lint policyValidation
uv lockuv syncuv run --frozen ruff check .uv run --frozen mypy langfuse --no-error-summaryuv run --frozen pytest tests/test_version.py -quv build --no-sourcesuv run --isolated --no-project --with dist/*.whl ...uv run --isolated --no-project --with dist/*.tar.gz ...uv run --frozen pre-commit run --all-filesResidual note
langfuse/api/core/pydantic_utilities.py; this migration leaves that behavior unchangedDisclaimer: Experimental PR review
Greptile Summary
This PR migrates the Langfuse Python SDK from Poetry to uv across all tooling layers: project metadata, lock file, CI workflows, release automation, pre-commit hooks, and developer documentation. It also replaces the hardcoded
langfuse/version.pywith a metadata-drivenlangfuse/_version.pyusingimportlib.metadata. One P2 concern was raised about the release workflow leavinguv.lockstale after a version bump.Confidence Score: 4/5
Clean migration with one uncertain failure mode in the release workflow around stale uv.lock
All functional changes are correct. The sole concern is the release workflow leaving uv.lock stale after a version bump, which could break uv sync --locked in CI on post-release main commits depending on uv's behavior for editable installs.
release.yml — version-bump and commit steps that omit uv.lock
Important Files Changed
Reviews (1): Last reviewed commit: "migrate repo from poetry to uv" | Re-trigger Greptile