Skip to content

Conversation

@GMartin-dev
Copy link
Contributor

Langchain new LCEL runnables allow you to override the name of entities.
https://python.langchain.com/docs/expression_language/interface
image

Langfuse is not applying this override into traces.
THis changes take trace and spans names from the override variables by default and fallback to the class names, etc etc.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024

CLA assistant check
All committers have signed the CLA.

@hassiebp
Copy link
Contributor

hassiebp commented Feb 8, 2024

Thanks a lot for your contribution @GMartin-dev 🙏🏾 🚀 I'll take it from here!

@hassiebp hassiebp changed the base branch from main to add-run-name-override-support February 8, 2024 16:17
@hassiebp hassiebp merged commit 289252e into langfuse:add-run-name-override-support Feb 8, 2024
hassiebp added a commit that referenced this pull request Feb 9, 2024
* New get_langchain_run_name() method as wrapper to get the "run_name" from LCEL config overrides or fullbacks to langchain class properties.

* Add Lcel test coverage for "run_name" override.

* Formatting tweaks.

Co-authored-by: German Martin <gmartin.py@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants